Skip to content

Use raw string for re.sub repl argument #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benyakirten wants to merge 4 commits into from
Closed

Use raw string for re.sub repl argument #84

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3883a75
Fix directional visibility handling (#1)
alex-lee Dec 2, 2024
72557ba
docs(parser): update comment for TAF time string parsing
benyakirten Aug 7, 2025
8f837ca
Merge pull request #2 from springblock-org/bh/793-error-parsing-taf-t…
benyakirten Aug 7, 2025
af786f3
Change _extracT_lines_tokens to use raw string for repl arg
benyakirten Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion metar_taf_parser/parser/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ def parse_delivery_time(abstract_weather_code, time_string):
Parses the delivery time of a METAR/TAF. It will return False
if it is not a delivery time but a validity time. If the delivery time
is not specified, we can assume the start of the validity time is the delivery time.

This occurred in the line TEMPO 2308/2312 9999/8000 RA/DZ BKN020, where the delivery time is
2300/2312, but the validity time that follows, 9999/9000 was parsed as a delivery time,
causing the parser to give erroneous results.

:param abstract_weather_code: The TAF or METAR object
:param time_string: The string representing the delivery time
:return: None
Expand Down Expand Up @@ -313,7 +318,7 @@ def _extract_lines_tokens(self, taf_code: str):
"""
single_line = taf_code.replace('\n', ' ')
clean_line = re.sub(r'\s{2,}', ' ', single_line)
lines = re.sub(r'\s(PROB\d{2}\sTEMPO|TEMPO|INTER|BECMG|FM(?![A-Z]{2}\s)|PROB)', '\n\g<1>', clean_line).splitlines()
lines = re.sub(r'\s(PROB\d{2}\sTEMPO|TEMPO|INTER|BECMG|FM(?![A-Z]{2}\s)|PROB)', r'\n\g<1>', clean_line).splitlines()
lines_token = [self.tokenize(line) for line in lines]

if len(lines_token) > 1:
Expand Down
Loading