-
-
Notifications
You must be signed in to change notification settings - Fork 63
change: Reorganize as griffe and griffelib packages with uv workspaces
#435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@copilot Remember that |
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
griffe and griffelib packages with uv workspacesgriffe and griffelib packages with uv workspaces
Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
Updated the root |
johnslavik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to promote public interface usage (griffe check, python -m griffe ...) instead of griffecli directly.
pyproject.toml
Outdated
| [tool.hatch.metadata.hooks.uv-dynamic-versioning.optional-dependencies] | ||
| # The 'pypi' extra provides dependencies needed for the load_pypi functionality | ||
| # to download and inspect packages from PyPI. | ||
| pypi = ["pip>=24.0", "platformdirs>=4.2", "wheel>=0.42"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this out to griffelib configuration and here do:
| pypi = ["pip>=24.0", "platformdirs>=4.2", "wheel>=0.42"] | |
| pypi = ["griffelib[pypi]=={{version}}"] |
And use double brackets for version interpolation with uv dynamic versioning everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in commit 1ef3a63. Changed pypi optional dependency in root griffe to re-export griffelib[pypi]=={{version}} and updated all version interpolations to use double brackets {{version}}.
…[pypi] Co-authored-by: johnslavik <64036239+johnslavik@users.noreply.github.com>
For reviewers
Description of the change
Fixes package separation issues from the migration script. The three packages now have correct dependencies with 1:1 version matching using
{{version}}interpolation:[pypi]extra for PyPI loading functionalitygriffelib=={{version}}griffelib=={{version}}andgriffecli=={{version}}, with[pypi]extra re-exportinggriffelib[pypi]=={{version}}Key fixes:
griffecliimports fromgriffelib/__init__.py(library must not depend on CLI)griffecli/__init__.py(main, check, dump, get_parser, DEFAULT_LOG_LEVEL){{version}}for version-locked dependencies[pypi]extra to re-exportgriffelib[pypi]=={{version}}Relevant resources
griffetogriffeandgriffelibpackages #408griffeandgriffelibpackages with uv workspaces #431, based on Prepare for 2.0 (finalize deprecations) #433💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.