Skip to content

Comments

Bump org.jboss:jboss-parent from 51 to 52#265

Merged
jajik merged 2 commits intomainfrom
dependabot/maven/org.jboss-jboss-parent-52
Feb 13, 2026
Merged

Bump org.jboss:jboss-parent from 51 to 52#265
jajik merged 2 commits intomainfrom
dependabot/maven/org.jboss-jboss-parent-52

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 13, 2026

Bumps org.jboss:jboss-parent from 51 to 52.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.jboss:jboss-parent](https://github.com/jboss/jboss-parent-pom) from 51 to 52.
- [Release notes](https://github.com/jboss/jboss-parent-pom/releases)
- [Commits](https://github.com/jboss/jboss-parent-pom/commits)

---
updated-dependencies:
- dependency-name: org.jboss:jboss-parent
  dependency-version: '52'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 13, 2026
@jajik jajik merged commit 1566407 into main Feb 13, 2026
2 checks passed
@jajik jajik deleted the dependabot/maven/org.jboss-jboss-parent-52 branch February 13, 2026 08:52
@jajik
Copy link
Member

jajik commented Feb 13, 2026

@rhusar I was able to merge a PR that has a commit from me. Do we want this? I think there's an option that can restrict that.

@rhusar
Copy link
Member

rhusar commented Feb 13, 2026

@jajik Well, this is not exactly the right fix as I don't have time to verify this works with a newer JDK. The correct fix was supposed to be to restore the original behavior of the parent

<jdk.min.version>${maven.compiler.release}</jdk.min.version>

@rhusar
Copy link
Member

rhusar commented Feb 13, 2026

@rhusar I was able to merge a PR that has a commit from me. Do we want this? I think there's an option that can restrict that.

That's because only main is protected, so you pushed to somebody else's branch and then can approve it since it's not your PR.

So basically you used a loophole.

@jajik
Copy link
Member

jajik commented Feb 13, 2026

@rhusar I was able to merge a PR that has a commit from me. Do we want this? I think there's an option that can restrict that.

That's because only main is protected, so you pushed to somebody else's branch and then can approve it since it's not your PR.

So basically you used a loophole.

Do we have Require approval of the most recent reviewable push checked?

@rhusar
Copy link
Member

rhusar commented Feb 13, 2026

This is documentation, we don't want to be stricter than necessary. We need to have a balance for efficiency. Same way we do not require branches to be up to date because it does not matter.

@rhusar
Copy link
Member

rhusar commented Feb 13, 2026

@jajik Anyway, everything looks good, lets stick with JDK 25 (we could even ditch maven and Java altogether here and use assciidoc directly if we want to..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants