Conversation
Bumps [org.jboss:jboss-parent](https://github.com/jboss/jboss-parent-pom) from 51 to 52. - [Release notes](https://github.com/jboss/jboss-parent-pom/releases) - [Commits](https://github.com/jboss/jboss-parent-pom/commits) --- updated-dependencies: - dependency-name: org.jboss:jboss-parent dependency-version: '52' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
@rhusar I was able to merge a PR that has a commit from me. Do we want this? I think there's an option that can restrict that. |
|
@jajik Well, this is not exactly the right fix as I don't have time to verify this works with a newer JDK. The correct fix was supposed to be to restore the original behavior of the parent |
That's because only main is protected, so you pushed to somebody else's branch and then can approve it since it's not your PR. So basically you used a loophole. |
Do we have Require approval of the most recent reviewable push checked? |
|
This is documentation, we don't want to be stricter than necessary. We need to have a balance for efficiency. Same way we do not require branches to be up to date because it does not matter. |
|
@jajik Anyway, everything looks good, lets stick with JDK 25 (we could even ditch maven and Java altogether here and use assciidoc directly if we want to..) |
Bumps org.jboss:jboss-parent from 51 to 52.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)