Add log level setting in UI #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This fixes modelcontextprotocol#188 * In App.tsx - import LoggingLevel from sdk - add [logLevel, setLogLevel] useState with value of type LoggingLevel initialized to "debug" - add useEffect that stores the new logLevel in localStorage as "logLevel" - added sendLogLevelRequest function that takes a level argument of type LoggingLevel and sends the appropriate request. It calls setLogLevel when done, to update the local UI - pass logLevel and sendLogLevelRequest to Sidebar component as props * In Sidebar.tsx - Import LoggingLevel and LoggingLevelSchema from sdk - add props and prop types for logLevel and sendLogLevelRequest and loggingSupported - add Select component populated with the enum values of LoggingLevelSchema, shown only if loggingSupported is true and connectionStatus is "connected" *
olaservo
reviewed
Mar 18, 2025
Member
|
Looks good to me, could you grab the latest from main? I think it will still prevent me from merging if I do it myself from the UI. |
olaservo
approved these changes
Mar 21, 2025
IgnacioC44
referenced
this pull request
in MCPJam/inspector
Jun 21, 2025
Add log level setting in UI
This was referenced Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We previously had an error report of log messages not getting through to the client. We added that functionality, but then had no way to set the logging level from the client, so we couldn't demonstrate a server respecting the set log level. More history in the issue.
How Has This Been Tested?
No Logging Level combo is shown when not connected
Logging Level combo is shown when connected to a server that supports logging.
Server support
Ran the Everything server with changes made to track and respect the log level set by the client.
In this screenshot, I've set the level to "warning" and only warning and higher messages are sent.
Breaking Changes
Nope.
Types of changes
Checklist
Additional context