Improve error handling for message enqueue failure#283
Closed
codeboyzhou wants to merge 6 commits intomodelcontextprotocol:mainfrom
codeboyzhou:main
Closed
Improve error handling for message enqueue failure#283codeboyzhou wants to merge 6 commits intomodelcontextprotocol:mainfrom codeboyzhou:main
codeboyzhou wants to merge 6 commits intomodelcontextprotocol:mainfrom
codeboyzhou:main
Conversation
- Update sendMessage method to provide more detailed error information - Remove unnecessary imports and improve code readability
srijit219
approved these changes
Jun 5, 2025
Contributor
Author
|
This PR is not very important, so consider closing it temporarily to avoid the frequent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
While debugging an MCP server in STDIO mode, I encountered
RuntimeException: Failed to enqueue message. The exception stack trace pointed toStdioMcpSessionTransport#sendMessage()but without more error details, I can only see thatoutboundSink.tryEmitNext(message).isSuccess()actually returnfalsebut there is no more helpful info to locate the root cause what results in thisfalse. I think the return value oftryEmitNext(message)is needed to be included in the error message to make it more clear.How Has This Been Tested?
Yes, I tested this in my local MCP server example application.
Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context
No additional context