Do not raise discard McpError when got unrecognized SSE event type#421
Closed
ziscloud wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Do not raise discard McpError when got unrecognized SSE event type#421ziscloud wants to merge 1 commit intomodelcontextprotocol:mainfrom
ziscloud wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…therwise it will fail the MCP client function
Contributor
|
likely related to the #413 |
Contributor
|
@ziscloud it is not safe to discard request response messages. This could lead to hanging requests. Can you please elaborate how to reproduce this issue? |
Contributor
9 tasks
tzolov
added a commit
that referenced
this pull request
Jul 25, 2025
…nts (#423) - Replace McpError exceptions with debug/warning logs for unrecognized SSE event types - Continue processing instead of failing when encountering unknown SSE events - Update transport implementations: - WebClientStreamableHttpTransport: return empty tuple instead of throwing - WebFluxSseClientTransport: complete stream instead of erroring - HttpClientSseClientTransport: call sink.success() instead of sink.error() - HttpClientStreamableHttpTransport: return empty Flux for unknown events This improves client resilience when servers send non-standard or future SSE event types. Resolves #272 , #223 , #93, #421 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Contributor
|
Closing as addressed by the #423 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not raise discard McpError when got unrecognized SSE event type, otherwise it will fail the MCP client function
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context