Use SchemaValidator to validate tool input #203
Merged
+103
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
#193 totally skipped my mind. This was exactly the purpose for the Haven't gone through the code yet, but seeing this reminded me of that...so you're definitely thinking in the right direction 👍🏼 |
Nyholm
commented
Dec 27, 2025
| break; | ||
| case 'type': | ||
| $expected = implode('|', (array) ($args['expected'] ?? [])); | ||
| $used = $args['used'] ?? 'unknown'; |
Contributor
Author
There was a problem hiding this comment.
Looking at the opis/json-schema package, I cannot find that $args['used'] is ever set.
chr-hertel
reviewed
Jan 2, 2026
scutuatua-crypto
approved these changes
Jan 10, 2026
chr-hertel
force-pushed
the
use-schema-validator
branch
from
cf9eab3 to
d81e7ae
Compare
Member
|
Rebased after #153 and switched to v0.3.0 |
chr-hertel
force-pushed
the
use-schema-validator
branch
from
d81e7ae to
04781f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opposite of #193. Let's use the unused SchemaValidator
Motivation and Context
Since we have an input schema, we can validate the input to match the schema. This makes it easier to write a tool.
How Has This Been Tested?
Unit tests and inspector
Breaking Changes
Nope
Types of changes
Checklist
Additional context