Propagate contextvars through anyio streams#1996
Draft
aabmass wants to merge 5 commits intomodelcontextprotocol:mainfrom
Draft
Propagate contextvars through anyio streams#1996aabmass wants to merge 5 commits intomodelcontextprotocol:mainfrom
aabmass wants to merge 5 commits intomodelcontextprotocol:mainfrom
Conversation
c0ccbcd to
b5cb58e
Compare
TODO: - Update a recipe to show it working - Consider adding an integration test of some kind
b5cb58e to
5f61a7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #421
This PR propagates
contextvars.Contextthrough internal anyio memory streams and restores it in long running async tasks, so that they run with the correct context.Motivation and Context
The goal is to make contextvars "work" with the MCP SDK as users expect. The main motivation is OpenTelemetry #421, but there are other use cases e.g. stdlib
decimal, starlette-context, etc.How Has This Been Tested?
Added several integration tests which are failing at
main. I also manually tested e2e with the some of the samples by using OpenTelemetry httpx instrumentation (I can share screenshots).Tests failures at main
Breaking Changes
No
Types of changes
Checklist
Additional context
N/A