Skip to content

Conversation

@buvinghausen
Copy link
Contributor

Just fixing the LegacyKeyValueFormat warning messages by adding the equals signs to the two lines

image

Description

I'm in the process of building out a DI friendly client library for all the servers published to docker to use with the csharp-sdk and noticed the puppeteer image was reporting two warnings.

Server Details

  • Server: puppeteer
  • Changes to: Dockerfile

Motivation and Context

Simply fixing the warnings
image

How Has This Been Tested?

Tested on WSL2 running in Fedora via Docker Desktop on Windows

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

N/A

@olaservo olaservo added server-puppeteer bug Something isn't working labels Apr 18, 2025
Copy link
Member

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@olaservo olaservo merged commit 0ad83e8 into modelcontextprotocol:main May 5, 2025
25 checks passed
PazerOP referenced this pull request in PazerOP/mcp-template Jul 15, 2025
Fix docker warnings in Puppeteer dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants