Skip to content

Conversation

@YuDavidCao
Copy link
Contributor

fix: puppeteer readme launch option json missing comma

Description

Server Details

  • Server:
  • Changes to:

Motivation and Context

I tried copying the launch json on puppeteer and notice that it's missing a comma

How Has This Been Tested?

I tested it with my mcp server. It doesn't work without the comma and worked with the comma

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

Copy link
Member

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@olaservo olaservo merged commit 0d12ab3 into modelcontextprotocol:main Apr 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants