Skip to content

Conversation

@olaservo
Copy link
Member

@olaservo olaservo commented May 5, 2025

Fixes viewport reset issue mentioned in #1347

Description

This PR fixes an issue where the browser viewport resets to 800x600 even when custom dimensions are set in PUPPETEER_LAUNCH_OPTIONS. It also adds documentation on what to expect when using tool params vs launch options.

Server Details

  • Server: puppeteer
  • Changes to: tools, documentation

Motivation and Context

The puppeteer server doesn't currently maintain viewport settings from PUPPETEER_LAUNCH_OPTIONS across operations. This causes inconsistent behavior where the viewport will reset to default hard-coded dimensions (800x600) even when custom dimensions are passed in the launch options.

How Has This Been Tested?

Still needs more testing in the following scenarios:

  • Setting viewport via PUPPETEER_LAUNCH_OPTIONS
  • Setting viewport via tool call parameters
  • Mixing environment and tool call settings
  • Taking screenshots with and without explicit dimensions
  • Verifying viewport persistence across operations

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client (WIP, see above)
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

@olaservo
Copy link
Member Author

Thanks for contributing this PR. This server has been moved to the archived repository at https://github.com/modelcontextprotocol/servers-archived to reduce maintenance overhead, so we can focus our efforts on a smaller set of core servers.
Since we're no longer accepting contributions to this server, we won't be able to merge this PR. If you're interested in contributing similar functionality, we recommend checking out the alternatives listed in the Readme.

@olaservo olaservo closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant