Skip to content

Fix Not Connected Error in Everything Streamable HTTP Server #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charlotte-zhuang wants to merge 2 commits into from
Closed

Fix Not Connected Error in Everything Streamable HTTP Server #1844

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f17a28
Fix Not Connected Error in Everything Streamable HTTP Server
May 20, 2025
149ed4f
rename variable
May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/everything/streamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ console.error('Starting Streamable HTTP server...');

const app = express();

const { server, cleanup } = createServer();
const serverCleanupHooks: (() => Promise<void>)[] = [];

const transports: { [sessionId: string]: StreamableHTTPServerTransport } = {};

Expand Down Expand Up @@ -47,6 +47,8 @@ app.post('/mcp', async (req: Request, res: Response) => {

// Connect the transport to the MCP server BEFORE handling the request
// so responses can flow back through the same transport
const { server, cleanup } = createServer();
serverCleanupHooks.push(() => cleanup().then(() => server.close()));
await server.connect(transport);

await transport.handleRequest(req, res);
Expand Down Expand Up @@ -167,8 +169,7 @@ process.on('SIGINT', async () => {
console.error(`Error closing transport for session ${sessionId}:`, error);
}
}
await cleanup();
await server.close();
await Promise.all(serverCleanupHooks);
console.error('Server shutdown complete');
process.exit(0);
});