-
Notifications
You must be signed in to change notification settings - Fork 9.1k
feat(filesystem): add --ignore-write option to block writes to sensit… #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(filesystem): add --ignore-write option to block writes to sensit… #1901
Conversation
|
Hi @tadasant |
|
Hi! @olaservo please review. |
|
Hi @olaservo... Do you think we need to change something in this? |
Hi @SOURABHMISHRA5221 ! Thanks for the ping and sorry for the wait. I've started reviewing this and other filesystem PRs that relate to file exclusion patterns and restrictions, since there are a few out there, and we've also been doing some security hardening on this server. I expect to leave feedback on these soon, but if you don't hear back next week feel free to @ me again. We had a huge backlog of Readme updates that were adding some noise to mentions but I will keep an eye out. Thanks! |
|
Hi @olaservo!... Hope you're doing well. Just wanted to follow up on the PR review when you get a chance. |
Title:
feat(filesystem): add --ignore-write option to block writes to sensitive files (#1869)
Description:
This PR addresses issue #1869 by adding a flexible mechanism to prevent accidental overwrites of sensitive files (such as
.env) in the Filesystem MCP server.Summary of changes:
--ignore-write <pattern1> <pattern2> ...command-line argument to the filesystem server..env,.env.*,*.secret, etc.), even if the file is within an allowed directory.Motivation:
Previously, the server could overwrite sensitive files (e.g.,
.env) without confirmation, risking data loss. This change allows users to specify which files should never be overwritten, improving safety and flexibility.Testing:
Documentation:
--ignore-writeoption.Checklist: