Skip to content

fix: MCP error -32603: Cannot read properties of undefined (reading 'toLowerCase') #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caizhiqiangzeyuan wants to merge 2 commits into from
Closed

fix: MCP error -32603: Cannot read properties of undefined (reading 'toLowerCase') #2054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f25ea75
fix:Cannot read properties of undefined (reading 'toLowerCase') Error
caizhiqiangzeyuan Jun 9, 2025
3e17b88
Merge branch 'main' into bugfix/searchNodes_toLowerCase_error
olaservo Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/memory/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,23 @@ class KnowledgeGraphManager {
async searchNodes(query: string): Promise<KnowledgeGraph> {
const graph = await this.loadGraph();

// Map to safe lower case
function toSafeLowerCase(str: unknown): string {
if (typeof str !== 'string') return '';
return str.trim().toLowerCase();
}

// Filter entities
const filteredEntities = graph.entities.filter(e =>
e.name.toLowerCase().includes(query.toLowerCase()) ||
e.entityType.toLowerCase().includes(query.toLowerCase()) ||
e.observations.some(o => o.toLowerCase().includes(query.toLowerCase()))
);
const filteredEntities = graph.entities.filter(e => {
const lowerQuery = toSafeLowerCase(query);

return (
toSafeLowerCase(e.name).includes(lowerQuery) ||
toSafeLowerCase(e.entityType).includes(lowerQuery) ||
(Array.isArray(e.observations) &&
e.observations.some(o => toSafeLowerCase(o).includes(lowerQuery)))
);
});

// Create a Set of filtered entity names for quick lookup
const filteredEntityNames = new Set(filteredEntities.map(e => e.name));
Expand Down