Skip to content

Conversation

@bbartels
Copy link
Contributor

@bbartels bbartels commented Jun 23, 2025

Description

Adds ability to disable thought logging via the DISABLE_THOUGHT_LOGGING env var

Server Details

  • Server: sequentialthinking
  • Changes to: logging

Motivation and Context

Some deployments may require sensitive information not be logged

How Has This Been Tested?

Ran the MCP server locally, added the ENV var and observed thoughts not being logged

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

@bbartels
Copy link
Contributor Author

@cliffhall Could I get a review on this? :) Not sure what the convention is to request reviews from maintainers

Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small request

Co-authored-by: Cliff Hall <cliff@futurescale.com>
@bbartels
Copy link
Contributor Author

Changed, thanks

Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@cliffhall cliffhall merged commit b7c48c7 into modelcontextprotocol:main Jun 23, 2025
15 checks passed
PazerOP referenced this pull request in PazerOP/mcp-template Jul 15, 2025
Adds ability to disable thought logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants