Skip to content

Conversation

@olaservo
Copy link
Member

@olaservo olaservo commented Jul 3, 2025

@ofek
Copy link

ofek commented Jul 3, 2025

Can you please incorporate the change I just pushed? https://github.com/modelcontextprotocol/servers/pull/2225/files

@olaservo
Copy link
Member Author

olaservo commented Jul 3, 2025

Can you please incorporate the change I just pushed? https://github.com/modelcontextprotocol/servers/pull/2225/files

@ofek done!

Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@cliffhall cliffhall merged commit 33a5d11 into modelcontextprotocol:main Jul 3, 2025
18 checks passed
@Craftzman7
Copy link
Contributor

Looking at the diff, this does not integrate the changes made in #2212 despite being listed in the PR body.

@cliffhall
Copy link
Member

@Craftzman7 Yep. Looks like these changes somehow slipped through the cracks of the automated process. That process is geared toward additions and may need to be amended for updates. Thanks for pinging us about it.

@modesty modesty mentioned this pull request Jul 3, 2025
12 tasks
@olaservo
Copy link
Member Author

olaservo commented Jul 3, 2025

Hi @Craftzman7, sorry, I think too much time passed between when I ran the initial data aggregation step and then generated the PR, so I missed your changes. Will keep that in mind for next time. But it looks like @cliffhall merged your latest change separately. 👍

@custom-discoveries
Copy link
Contributor

Is there any chance you could incorporate the change that I have pushed?
#2187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants