Skip to content

Conversation

@evalstate
Copy link
Member

As per title

Description

The everything server was emitting notifications/stderr a type not in the MCP Schema (and causing exceptions from the Python SDK).

Server Details

The everything server.

Motivation and Context

Make it compliant with the MCP.

How Has This Been Tested?

Local running.

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

@evalstate evalstate requested review from cliffhall and olaservo August 2, 2025 07:49
…cy test advice.

2) Make the Unit Test insensitive to the git default branch name
…ove legacy test advice."

(wrong branch push)
This reverts commit b43ecf8.
@olaservo olaservo merged commit 78e5a17 into main Aug 2, 2025
22 checks passed
@olaservo olaservo deleted the fix/remove-stderr branch August 2, 2025 17:18
@cliffhall
Copy link
Member

cliffhall commented Aug 4, 2025

@olaservo thanks for this. I added it, because I saw previous support for it in the Inspector. Didn't even go looking at the spec, since it was added by a core team member. We will want to remove that as well.

Screenshot 2025-08-04 at 11 50 51 AM

@evalstate
Copy link
Member Author

Missed this comment at the time - yes, I guess the right thing to do is to handle the logging events.

@cliffhall
Copy link
Member

cliffhall commented Aug 21, 2025

Missed this comment at the time - yes, I guess the right thing to do is to handle the logging events.

@evalstate that is to say "Remove the out-of-spec notification/stderr handler from the client as well?" If so, I'm on that.

cliffhall added a commit to cliffhall/mcp-inspector that referenced this pull request Aug 21, 2025
… not a thing. See modelcontextprotocol/servers#2469

* Inspect the stderr output of STDIO servers and attempt to assign an appropriate RFC 5424 Syslog Protocol level before sending a leveled logging message to the client
cliffhall added a commit to cliffhall/mcp-inspector that referenced this pull request Aug 21, 2025
… not a thing. See modelcontextprotocol/servers#2469

* Inspect the stderr output of STDIO servers and attempt to assign an appropriate RFC 5424 Syslog Protocol level before sending a leveled logging message to the client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants