-
Notifications
You must be signed in to change notification settings - Fork 9.1k
UUID based resources #2596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
UUID based resources #2596
Conversation
Fixes issue where array indices (0-based) didn't match URI numbers (1-based), causing confusion where: - Resource at index 0 was accessed via 'test://static/resource/1' - Even indices (text resources) mapped to odd URI numbers Changes: - Resource URIs now use 0-based numbering to match array indices - Resource 0 is now accessed via 'test://static/resource/0' - Even indices now map to even URI numbers (more intuitive) Resolves #475 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Ola Hungerford <olaservo@users.noreply.github.com>
…c paths Implements @domdomegg's proposal to use UUIDs for resource identification instead of array indices: - Generate UUIDs for all 100 resources (50 text, 50 blob) - Use semantic paths: test://static/resource/text/{uuid} and test://static/resource/blob/{uuid} - Remove dependency on array indices for URI construction - Update resource templates to reflect new URI patterns - Modify getResourceReference tool to accept resourceUri instead of resourceId - Update resource_prompt argument from resourceId to resourceUri - Improve resource link descriptions to mention UUID-based identification - Update README documentation to reflect UUID-based system This eliminates the confusion between array indices (0-based) and URI numbers (1-based) while providing more intuitive resource categorization through semantic paths. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: adam jones <domdomegg@users.noreply.github.com>
|
Claude finished @domdomegg's task —— View job SummaryThis PR replaces the problematic array index-based resource system with UUID-based semantic paths, resolving issue #475 and implementing the solution proposed in issue #2570. Changes MadeCore Implementation Changes (
|
cliffhall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@claude could you update this PR to interleave the resource types as suggested in the previous comment? |
|
Claude finished @olaservo's task —— View job Summary✅ Successfully updated the PR to interleave resource types as requested. The resources now alternate between text and blob (Text, Blob, Text, Blob, etc.) instead of generating all text resources followed by all blob resources. Changes MadeImplementation DetailsResource Generation Logic (
Before: After: Benefits Restored
Verification
Todo List
The PR now has the requested interleaving pattern while maintaining all the benefits of UUID-based resource identification! |
Previously resources were generated as 50 text resources followed by 50 blob resources. Now they alternate: Text, Blob, Text, Blob, etc. This provides better variety when using tools like getResourceLinks and maintains the useful interleaving pattern that was present before the UUID-based refactor. Co-authored-by: Ola Hungerford <olaservo@users.noreply.github.com>
|
@cliffhall is this more what you were thinking? (This is a screenshot from pulling the latest from this PR and then building it locally, and testing in latest Inspector.) |
@olaservo Yeah, but the new naming makes it fugly. It really would be better if the resource names were what they once were (Resource 1 ... Resource 100). Only when you selected a resource or listed it with the getResources or getResourceLinks tools did you really see the further detail about types. |



Fixes #475
Also see #2570