Make presence of startElicitation tool conditional on client support
#2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or elicitation capability * In everything.ts - remove inappropriate elicitation entry from server capabilities (this is a client capability) - When creating tool list, only add `ToolName.ELICITATION` definition to tools array if `clientCapabilities` includes `elicitation` * In package.json / package-lock.json - bump @modelcontextprotocol/sdk to "^1.17.4", adding `elicitation` to `ClientCapabilities` type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
server-everything, suppressstartElicitationtool if client does not advertise support for elicitation capability.In
everything.tsToolName.ELICITATIONdefinition to tools array ifclientCapabilitiesincludeselicitationIn
package.json&package-lock.json@modelcontextprotocol/sdkto^1.17.4, addingelicitationtoClientCapabilitiestypeServer Details
everythingMotivation and Context
If the client does not support elicitations, the
startElicitationtool will cause an error when run.Currently, When Client Doesn't Support Elicitation
How Has This Been Tested?
Commented out elicitation support in the Inspector. Tried with and without elicitiations, showing that the
startElicitationtool is only shown if the client supports it.When Client Supports Elicitation
When Client Doesn't Support Elicitation
Breaking Changes
Nope.
Types of changes
Checklist
Additional context