Skip to content

Let Everything's STDIO server use SDK's automatic log level handling #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
domdomegg merged 1 commit into from
Sep 12, 2025
Merged

Let Everything's STDIO server use SDK's automatic log level handling #2706

domdomegg merged 1 commit into from
Sep 12, 2025

Conversation

@cliffhall
Copy link
Member

@cliffhall cliffhall commented Sep 11, 2025 •
edited
Loading

Description

  • In src/everything/package.json
    • bump TS SDK to 1.18.0
  • In src/everything/stdio.ts
    • remove logging related imports
    • remove custom log-level handling, now handled automatically by the SDK
  • In src/everything/everything.ts
    • remove console.log of sessionId

Server Details

  • Server: Everything / stdio
  • Changes to: log level handling

Motivation and Context

The automatic log level handling fix for stdio servers has been merged and included in the new SDK release. As a temporary workaround until this fix could happen, the Everything stdio server previously had a custom log level handling implementation. This has been removed, and now, all three transports use the SDK's log level handling feature.

How Has This Been Tested?

Used inspector to test the Everything / stdio server.

  • Initially negotiated log level of debug allowed some info level messages to pass
  • Subsequently negotiated log level of alert only allowed alert and emergency messages to pass

Log Level Set to debug

debug

Log Level Set to alert

alert

Breaking Changes

Nope.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

@cliffhall
* In src/everything/package.json
a4a8a59 
  - bump TS SDK to 1.18.0
* In src/everything/stdio.ts
  - remove logging related imports
  - remove custom log-level handling, now handled automatically by the SDK
* In src/everything/everything.ts
  - remove console.log of sessionId
domdomegg
domdomegg reviewed Sep 12, 2025
View reviewed changes
domdomegg
domdomegg approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@domdomegg domdomegg merged commit c309373 into modelcontextprotocol:main Sep 12, 2025
21 checks passed
@cliffhall cliffhall deleted the everything-stdio-auto-log-level branch September 12, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domdomegg domdomegg domdomegg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cliffhall @domdomegg