-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Fix/memory server schema validation #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/memory server schema validation #2726
Conversation
- Add explicit property filtering in saveGraph method - Add additionalProperties constraints to input schemas
|
@olaservo @cliffhall Please take a look on this critical fix. |
|
@0dd could you allow access to the doc? I just requested it with my google account. |
|
I also requested access. |
Thanks @cliffhall added |
cliffhall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
|
Since this is a security fix for the report, could we cut a patch release as the patched version: @modelcontextprotocol/server-memory@0.6.4? I didn’t bump the version in the PR. I assumed releases are handled in a separate commit and reviewed by the maintainer team. We'll make a release out ASAP, it will change the server version to the dated release number. |
|
|
Hi team I saw this have been fixed in the version @modelcontextprotocol/server-memory@2025.9.25 @jenn-newton @cliffhall Can you also help request the CVE for this one? I have also discussed the detailed threat model through discord. The affected version was from npm version 0.2.0 till the date version <@2025.9.25 |
TLDR
Fix the critical Security Issue see the report
Description
Server Details
Motivation and Context
Security Issue: Please Check the report
How Has This Been Tested?
Test with Amazon Q and MCP CLI
Breaking Changes
All Users need to update to this version to prevent Security Issue (detailed in the link)
Types of changes
Checklist