Skip to content

Conversation

@cliffhall
Copy link
Member

@cliffhall cliffhall commented Sep 18, 2025

Description

  • In release.yml
    • remove comments that break CI.
    • github does not support comments, even though they are valid yaml

Motivation and Context

Comments added to release.yml in response to a review request broke CI. GIthub apparently does not support comments even though YAML does. This is probably why there is zero documentation about how to add comments to workflow files in GitHub's documentation.
Screenshot 2025-09-18 at 6 14 06 PM
.

How Has This Been Tested?

🤞🏻

Breaking Changes

Nope.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

  - remove comments that break CI.
  - github does not support comments, even though they are valid yaml
@cliffhall cliffhall requested a review from domdomegg September 18, 2025 22:16
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

maybe we can move this up instead so it's a yaml comment. sorry for my original mistake!

@domdomegg domdomegg merged commit 9280e8f into modelcontextprotocol:main Sep 19, 2025
19 checks passed
@cliffhall
Copy link
Member Author

lgtm

maybe we can move this up instead so it's a yaml comment. sorry for my original mistake!

AFAIK this was a valid YAML comment.

Screenshot 2025-09-19 at 12 41 54 PM

@cliffhall cliffhall deleted the remove-workflow-comments branch September 19, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants