Skip to content

Conversation

@0dd
Copy link
Contributor

@0dd 0dd commented Sep 24, 2025

TLDR

Fix the critical Security Issue see the report

  • Remove the attack path

Description

Server Details

  • Server: Git Server
  • Changes to: Tool

Motivation and Context

Security Issue: Please Check the report

How Has This Been Tested?

Test with Amazon Q and MCP CLI

Breaking Changes

All Users need to update to this version to prevent Security Issue (detailed in the link

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

@0dd
Copy link
Contributor Author

0dd commented Sep 24, 2025

Please DM me on Discord to discuss the technical details https://discord.com/channels/1358869848138059966/1379811011669921883/1420257622606483556

@0dd
Copy link
Contributor Author

0dd commented Sep 24, 2025

@cliffhall @olahungerford @domdomegg
Please take a look on this critical fix.

- `repo_path` (string): Path to Git repository
- `revision` (string): The revision (commit hash, branch name, tag) to show
- Returns: Contents of the specified commit
12. `git_init`
Copy link
Contributor Author

@0dd 0dd Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Thanks @0dd for finding and fixing this vulnerability.

@cliffhall cliffhall merged commit 582bc1d into modelcontextprotocol:main Sep 24, 2025
18 checks passed
@0dd
Copy link
Contributor Author

0dd commented Oct 10, 2025

Hi team I saw this have been fixed in the version mcp-server-git@2025.9.25.

Thank you all for the fix version build.

@cliffhall @jenn-newton Can you also help request the CVE for this one?

The vulnerability was introduced from https://github.com/modelcontextprotocol/servers/pull/551/files
The affected version was from date version 2025.2.2 to the version < @2025.9.25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants