Skip to content

Conversation

@evalstate
Copy link
Member

Send Sampling and Elicitation requests via the associated POST channel for the Tool Call.

Description

Server Details

  • Server: Everything
  • Changes to: Sampling and Elicitation Tools

Motivation and Context

Sampling and Elicitation Requests were being issued through the GET channel rather than associated with corresponding Tool Call. Causes hanging behaviour in clients.

How Has This Been Tested?

Tested STDIO and StreamableHTTP behavior. Suspect this hasn't been spotted in e.g. Inspector as the sampling request happens - just dissociated.
image
That yellow spot shows the new behavior - request received on the POST SSE stream.

Breaking Changes

No - this fixing things!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

Copy link
Contributor

@ochafik ochafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evalstate !

@ochafik ochafik merged commit 4604e75 into main Oct 3, 2025
23 checks passed
@ochafik ochafik deleted the fix/sample-elicit branch October 3, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants