-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Windows filesystem MCP enhancements #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add path-utils module for consistent path handling - Handle Windows paths with spaces via proper quoting - Support Unix-style Windows paths (/c/path) - Support WSL paths (/mnt/c/path) - Add comprehensive test coverage - Fix path normalization for all path formats Closes modelcontextprotocol#447
Fix windows paths
|
You need to incorporate this to normalize path like "c:\Users" to "C:\Users". |
Ensure Windows drive letters are capitalized in normalizePath
|
Incorporated logic to hand lowercase drive letters per @m2self suggestion - tested and working locally |
|
Can this handle "special" characters in the folder name? For example the ampersand in "C:\Sub&Folder" In my 0.7.7.0 release of the Windows desktop app, including the "C:\NS\Sub&Folder" entry in claude_desktop_config.json |
|
@NemanSyed yes the normalize path function takes care of that, added some tests for ya and here is a SS of it working locally for me |
|
Great, thanks @mfcasazza! Looking forward to getting this working! Edit: Just tried with Claude desktop app 0.8.8.0. It still breaks if the path has spaces in it or it it has any "special" characters (I tested with &). How do I confirm I'm using your enhancements? |
|
@NemanSyed my pull request is still open and hasn't been merged - you'd need to clone my code, build locally and point your filesystem config to the local version - my config looks like this and is what was working in my screenshot 4 days ago |
|
Thanks @mfcasazza. That's beyond my skill level at this point - I'll wait for the merge. Thank you for the new code and explanation! |
|
Hi @mfcasazza thanks for opening this, fyi since a lot has changed since your last push I went ahead and:
I am getting more 👀 on this PR to get it merged in, so let me know if you'd like to pick this up again to get it through the finish line. Or I can just take care of any necessary adjustments before merging, for the sake of expediting. |
|
@olaservo I'm on a climbing trip until next Wednesday - happy to pick it up then but if you'd like to merge it feel free - thanks |



Description
Added support for Windows file paths with spaces in them. Also added support for linked directories.
Server Details
Motivation and Context
I ran into this bug: #447 when trying to use the claude desktop app.
How Has This Been Tested?
Tested extensively with Claude desktop client on Windows using multiple scenarios:
Breaking Changes
No breaking changes. Existing configurations should continue to work as before - I tested locally with my desktop and downloads folders
Types of changes
Checklist
Additional context
I don't have a mac - the code shouldn't affect mac paths - however was not able to test that locally