Skip to content

Conversation

@dbworku
Copy link

@dbworku dbworku commented Feb 23, 2025

Description

Some of the pull request operations listed in the README never had tool registrations or handlers. The implementations looked fine; just closing the last mile for:

  • get_pull_request_status
  • update_pull_request_branch
  • get_pull_request_comments
  • get_pull_request_reviews
  • merge_pull_request

Server Details

  • Server: github
  • Changes to: tools

Motivation and Context

We want MCP Clients using this server to be able to use all of the tools that we list in the documentation.

How Has This Been Tested?

Built with:

➜  servers git:(register-all-tools) ✗ docker build -t mcp/github -f src/github/Dockerfile .
[+] Building 12.7s (15/15) FINISHED                       docker:desktop-linux
...
 => => exporting manifest list sha256:98865d3d57046c173e22b7d1391619eb06  0.0s
 => => naming to docker.io/mcp/github:latest                              0.0s
 => => unpacking to docker.io/mcp/github:latest                           0.2s

Addes to Claude Desktop with:

{
    "mcpServers": {
      "github": {
        "command": "docker",
        "args": [
          "run",
          "-i",
          "--rm",
          "-e",
          "GITHUB_PERSONAL_ACCESS_TOKEN",
          "mcp/github"
        ],
        "env": {
          "GITHUB_PERSONAL_ACCESS_TOKEN": "<REDACTED_FROM_PR>"
        }
      },
    }
  }

Created a prompt that uses the tools. Verified that various tool calls succeed.
Screenshot 2025-02-22 at 9 13 49 PM

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Added tool registrations and handlers for:
- get_pull_request_status
- update_pull_request_branch
- get_pull_request_comments
- get_pull_request_reviews
- merge_pull_request
@dbworku
Copy link
Author

dbworku commented Mar 9, 2025

🏓

@tadasant
Copy link
Member

Believe this was addressed in #728 - please correct me if there is more scope here worth including, will re-open.

Sorry that that PR duplicated the work :\

@tadasant tadasant closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants