fix: prevent TS2589 type instantiation error in ToolCallback #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Use [T] extends [U] pattern on the AnySchema check to prevent distributive conditional types. This fixes the "Type instantiation is excessively deep and possibly infinite" error that occurs when using registerTool after upgrading to v1.23.0. The issue was that AnySchema (z3.ZodTypeAny | z4.$ZodType) as a union caused TypeScript to distribute the conditional type check, leading to exponential type instantiation. Fixes #1180
felixweinberger
force-pushed
the
fweinberger/issue-1180
branch
from
68ccf6c to
192d981
Compare
Contributor
|
I'm not convinced this is the reason. We can revisit if it crops up in future though. |
Contributor
Author
yeah I couldn't actually repro on my machine, and looks like it didn't solve the reporter's issue either so having 2 zods next to each other like you said |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use [T] extends [U] pattern on the AnySchema check to prevent distributive conditional types.
Motivation and Context
Fixes #1180. After upgrading from v1.22.0 to v1.23.0, users get
TS2589: Type instantiation is excessively deep and possibly infinitewhen usingregisterTool. The issue was thatAnySchema(z3.ZodTypeAny | z4.$ZodType) as a union caused TypeScript to distribute the conditional type check, leading to exponential type instantiation.How Has This Been Tested?
npm run buildpassesnpm testpasses (1129 tests)npm run lintpassesBreaking Changes
None. This is a type-level fix only.
Types of changes
Checklist