Add root fallback for OAuth discovery when URL has path #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some servers incorrectly set authorization_servers to an endpoint path instead of the issuer URL, violating RFC 9470. Add a fallback to try root-level OAuth discovery (/.well-known/oauth-authorization-server) when path-based discovery fails. This allows discovery to succeed with non-compliant server implementations while maintaining spec-compliant behavior as the primary path.
commit: |
1 task
Contributor
Author
|
Closing this since it was fixed in better-auth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers incorrectly set authorization_servers to an endpoint path instead of the issuer URL, violating RFC 9470. Add a fallback to try root-level OAuth discovery (/.well-known/oauth-authorization-server) when path-based discovery fails. This allows discovery to succeed with non-compliant server implementations while maintaining spec-compliant behavior as the primary path.
Fixes this issue which apparently uses better-auth
cloudflare/agents#686
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context