fix(server): call onerror callback for all transport errors#1433
Open
codewithkenzo wants to merge 4 commits intomodelcontextprotocol:mainfrom
Open
fix(server): call onerror callback for all transport errors#1433codewithkenzo wants to merge 4 commits intomodelcontextprotocol:mainfrom
codewithkenzo wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
Adds missing onerror callback invocations before every createJsonErrorResponse call in WebStandardStreamableHTTPServerTransport. This ensures that transport errors are no longer silently swallowed and can be observed via the onerror callback. Changes: - Add this.onerror?.() calls to 15 locations in streamableHttp.ts - Add 10 test cases to verify onerror is called for various error conditions Fixes modelcontextprotocol#1395
🦋 Changeset detectedLatest commit: a4e1e5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This was referenced Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1395 - Transport errors are silently swallowed due to missing
onerrorcallback usage.This PR adds
this.onerror?.()calls before everycreateJsonErrorResponseinWebStandardStreamableHTTPServerTransport, ensuring that all transport errors are properly reported to the error callback.Changes
packages/server/src/server/streamableHttp.tsAdded
this.onerror?.(new Error(...))calls at 15 locations:handleGetRequest: Missing Accept header (406), concurrent SSE stream conflict (409)replayEvents: Event store not configured (400), invalid event ID format (400), stream conflict (409)handlePostRequest: Invalid Accept header (406), unsupported Content-Type (415), JSON parse error (400), invalid JSON-RPC message (400), re-initialization attempt (400), multiple init requests (400)validateSession: Server not initialized (400), missing session ID (400), session ID mismatch (404)validateProtocolVersion: Unsupported protocol version (400)packages/server/test/server/streamableHttp.test.tsAdded 10 test cases to verify
onerroris called for various error conditions:Testing
Pattern Used
Follows the existing pattern already present at lines 296, 306, etc.: