Skip to content

fix: README badges links destinations #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixweinberger merged 2 commits into from
Dec 19, 2025
Merged

fix: README badges links destinations #907

felixweinberger merged 2 commits into from
Dec 19, 2025
+1 −1

Conversation

@antonpk1
Copy link

@antonpk1 antonpk1 commented Aug 29, 2025 •
edited
Loading

Summary

Currently, clicking on the NPM version and license badges in the README opens the shield.io image URL, which isn't very useful. This PR makes these badges actually link to relevant pages.

Changes

  • NPM badge now links to the npm package page
  • License badge now links to the LICENSE file in the repo

This follows the pattern used by other projects like microsoft/playwright.

Breaking Changes

Nope.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@antonpk1 antonpk1 requested review from a team and felixweinberger August 29, 2025 13:25
@antonpk1 @claude
Make README badges link to useful destinations
7168a2c 
The NPM and license badges now link to:
- NPM badge → npm package page
- License badge → LICENSE file in repo

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@antonpk1 antonpk1 force-pushed the fix-readme-badge-links branch from de16d5a to 7168a2c Compare August 30, 2025 11:51
@antonpk1 antonpk1 changed the title Make README badges link to useful destinations fix: README badges links destinations Aug 31, 2025
@felixweinberger felixweinberger changed the base branch from main to v1.x December 19, 2025 16:45
@felixweinberger felixweinberger requested a review from a team as a code owner December 19, 2025 16:45
felixweinberger
felixweinberger approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@felixweinberger felixweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

⚠️ No Changeset found

Latest commit: 9fc53e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@felixweinberger felixweinberger enabled auto-merge (squash) December 19, 2025 16:46
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 19, 2025

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@907

commit: 9fc53e0

@felixweinberger felixweinberger merged commit a0c9b13 into modelcontextprotocol:v1.x Dec 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixweinberger felixweinberger felixweinberger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonpk1 @felixweinberger