Add starting point for figures in Blocks and ComplexBlocks.#4674
Draft
maltelenz wants to merge 1 commit intomodelica:masterfrom
Draft
Add starting point for figures in Blocks and ComplexBlocks.#4674maltelenz wants to merge 1 commit intomodelica:masterfrom
maltelenz wants to merge 1 commit intomodelica:masterfrom
Conversation
These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.
AHaumer
approved these changes
Sep 12, 2025
Contributor
AHaumer
left a comment
There was a problem hiding this comment.
just adding starting point for figures - thx @maltelenz - fine with me!
Contributor
|
I tested the implementation with Dymola2025x under Linux. Many examples worked fine, except for the ones using tables or handling files in a different way:
For I tested the listed models with the default installation of the MSL in Dymola2025x and they just worked fine. So the issue may be related with the specific git branch where some Linux libraries may not be working correctly. |
This was referenced Sep 21, 2025
Contributor
|
The table issue shall be handled in #4696. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.
Our one existing figure in MSL is probably a good style to follow:
ModelicaStandardLibrary/Modelica/Blocks/package.mo
Lines 159 to 180 in 3f72865
Creating as Draft to indicate that library officer(s) probably want/should improve them before merging.