-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[NPU]:Support USP feature in NPU #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Feng0w0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the USP (Unified Sequence Parallel) feature on NPU devices. The changes include adapting the code to use NPU-specific attention types and workarounds for tensor operations. Documentation is updated with instructions for NPU setup and usage, and a new training script for NPU is added. The overall approach is sound, but I've found a few issues that need addressing: a potential performance degradation on non-NPU devices, a duplicated configuration in pyproject.toml which will break package installation, and several temporary documentation files that seem to have been committed by mistake.
pyproject.toml
Outdated
| [project.optional-dependencies] | ||
| npu_aarch64 = [ | ||
| "torch==2.7.1", | ||
| "torch-npu==2.7.1", | ||
| "torchvision==0.22.1" | ||
| ] | ||
| npu = [ | ||
| "torch==2.7.1+cpu", | ||
| "torch-npu==2.7.1", | ||
| "torchvision==0.22.1+cpu" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| device='cpu') | ||
| original_tensor_device = original_tensor.device | ||
| padded_tensor = torch.cat([original_tensor.cpu(), padding_tensor], dim=0).to(device=original_tensor_device) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change forces tensor operations to be performed on the CPU, which might be a necessary workaround for NPU devices. However, this will introduce performance overhead for other devices like CUDA due to data transfers between CPU and GPU. It would be better to apply this logic conditionally, only for NPU devices, to avoid performance regressions on other platforms.
| @@ -0,0 +1,86 @@ | |||
| # GPU/NPU 支持 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By submitting PR to the xfuser and yunchang repositories, these two repositories already natively support NPU.
Supplement the installation methods of these two repositories on NPU and the NPU adaptation code for USP features for Diffsynth-Studio