feat(test-runner-junit-reporter): Add support for flat test files to junit-reporter#2904
Open
JackRobards wants to merge 1 commit intomodernweb-dev:masterfrom
Open
Conversation
…Web Test runner's junit-reporter
🦋 Changeset detectedLatest commit: 6d6ee2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
@bashmish Is this something you would have time to take a look at, or are there any changes I should make here? I totally get it if you're just busy with other things, but I wanted to check-in in case there's anything I can do here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add support for test files that do not use a
describeblock (aka "flat") to the junit-reporter.A file like this would now be included in the report, where before it would not:
As for what to call the Test Suite - I followed the same pattern that the
toResultsWithMetadataByBrowserTestFileNamefunction was using. So each of these test suites will be named based on the browser + file being tested.This should be a non-breaking change from my testing - it is only intended to detect some test cases that wouldn't be included previously!
closes #2901