Skip to content

Fix daedalus #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fetchfern merged 4 commits into from
Jan 8, 2026
Merged

Fix daedalus #5064

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bcf142
Support default-user-jvm arguments type
fetchfern Jan 8, 2026
2630012
Use this branch's container
fetchfern Jan 8, 2026
3d1716d
Allow no rules in Ruled argument variant
fetchfern Jan 8, 2026
de0abb7
Run main
fetchfern Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/daedalus/src/minecraft.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,20 +454,23 @@ pub enum Argument {
/// An argument which is only applied if certain conditions are met
Ruled {
/// The rules deciding whether the argument(s) is used or not
#[serde(default)]
rules: Vec<Rule>,
/// The container of the argument(s) that should be applied accordingly
value: ArgumentValue,
},
}

#[derive(Serialize, Deserialize, Debug, Eq, PartialEq, Hash, Clone, Copy)]
#[serde(rename_all = "snake_case")]
#[serde(rename_all = "kebab-case")]
/// The type of argument
pub enum ArgumentType {
/// The argument is passed to the game
Game,
/// The argument is passed to the JVM
Jvm,
/// Passed to JVM as well. Includes default arguments to the GC.
DefaultUserJvm,
}

#[derive(Serialize, Deserialize, Debug, Eq, PartialEq, Hash)]
Expand Down