-
Notifications
You must be signed in to change notification settings - Fork 246
feat(web, ci): upload compass-web assets to an s3 bucket during publish COMPASS-10132 #7631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc7a9e9 to
d7f51ce
Compare
d7f51ce to
3e30d7d
Compare
| test: /\.(jpe?g|png|svg|gif)(\?.+?)?$/, | ||
| // it's convenient to inline images as data-urls to make sure that publised | ||
| // library artifacts only produce importable javascript assets | ||
| type: 'asset/inline', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just easier not to deal with them for compass-web which is published as a library, they are all relatively small (the biggest is like 5kb) so data-urls work well enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is maybe an argument for this code to be a part of hadron-build upload script, but I didn't want to add to the code we already know we need to heavily refactor in the future. Keeping it closer to compass-web seems reasonable to me for now, we can move this all to one place later down the road
| - name: test-packaged-app-macos-15-x64 | ||
| display_name: Test Packaged App MacOS x64 15 | ||
| run_on: macos-15-amd64-gui | ||
| patchable: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by fix: at some point we updated the template (the .in file), but not the actual config
| GITHUB_TOKEN: ${devtoolsbot_github_token} | ||
| DOWNLOAD_CENTER_AWS_ACCESS_KEY_ID: ${aws_key_evergreen_integrations} | ||
| DOWNLOAD_CENTER_AWS_SECRET_ACCESS_KEY: ${aws_secret_evergreen_integrations} | ||
| DOWNLOAD_CENTER_NEW_AWS_ACCESS_KEY_ID: ${AWS_ACCESS_KEY_ID} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a bit of an overkill moving it here taking into account we will be using a different bucket, but this anyway seems more consistent with how we do it for other variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK. I have no real opinion.
|
Latest commit was built and uploaded just fine: https://downloads.mongodb.com/compass/web/263691e49fdaf45dc4c396b57ad48e3b3d467e80/compass-web.mjs Tested with redwood against deployed cloud environment and it loads okay without any extra changes required:
|
cd8b863 to
70bddfd
Compare
ivandevp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

This patch adds continuous publishing for compass-web assets to a publicly available resource. We're temporarily using the same bucket used for compass desktop installers (downloads.mongodb.com/compass), but will eventually move to its own dedicated one