fix: address comments

Author: fmenezes

README.md

@@ -162,12 +162,11 @@ The MongoDB MCP Server can be configured using multiple methods, with the follow
 
 ### Configuration Options
 
-| Option             | Description                                                                 |
-| ------------------ | --------------------------------------------------------------------------- |
-| `apiClientId`      | Atlas API client ID for authentication                                      |
-| `apiClientSecret`  | Atlas API client secret for authentication                                  |
-| `stateFile`        | Path to store application state (default ~/.mongodb/mongodb-mcp/state.json) |
-| `connectionString` | MongoDB connection string for direct database connections                   |
+| Option             | Description                                                                                                           |
+| ------------------ | --------------------------------------------------------------------------------------------------------------------- |
+| `apiClientId`      | Atlas API client ID for authentication                                                                                |
+| `apiClientSecret`  | Atlas API client secret for authentication                                                                            |
+| `connectionString` | MongoDB connection string for direct database connections (optional users may choose to inform it on every tool call) |
 
 ### Atlas API Access
 

src/tools/atlas/atlasTool.ts

@@ -10,7 +10,7 @@ export abstract class AtlasToolBase extends ToolBase {
         super(state);
     }
 
-    protected async ensureAuthenticated(): Promise<void> {
+    protected ensureAuthenticated(): void {
         if (!this.apiClient) {
             throw new Error(
                 "Not authenticated make sure to configure MCP server with MDB_MCP_API_CLIENT_ID and MDB_MCP_API_CLIENT_SECRET environment variables."

src/tools/atlas/createAccessList.ts

@@ -26,7 +26,7 @@ export class CreateAccessListTool extends AtlasToolBase {
         comment,
         currentIpAddress,
     }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
-        await this.ensureAuthenticated();
+        this.ensureAuthenticated();
 
         if (!ipAddresses?.length && !cidrBlocks?.length && !currentIpAddress) {
             throw new Error("One of  ipAddresses, cidrBlocks, currentIpAddress must be provided.");

src/tools/atlas/createDBUser.ts

@@ -33,7 +33,7 @@ export class CreateDBUserTool extends AtlasToolBase {
         roles,
         clusters,
     }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
-        await this.ensureAuthenticated();
+        this.ensureAuthenticated();
 
         const input = {
             groupId: projectId,

src/tools/atlas/createFreeCluster.ts

@@ -14,7 +14,7 @@ export class CreateFreeClusterTool extends AtlasToolBase {
     };
 
     protected async execute({ projectId, name, region }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
-        await this.ensureAuthenticated();
+        this.ensureAuthenticated();
 
         const input = {
             groupId: projectId,

src/tools/atlas/inspectAccessList.ts

@@ -11,7 +11,7 @@ export class InspectAccessListTool extends AtlasToolBase {
     };
 
     protected async execute({ projectId }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
-        await this.ensureAuthenticated();
+        this.ensureAuthenticated();
 
         const accessList = await this.apiClient!.listProjectIpAccessLists({
             params: {

src/tools/atlas/inspectCluster.ts

@@ -13,7 +13,7 @@ export class InspectClusterTool extends AtlasToolBase {
     };
 
     protected async execute({ projectId, clusterName }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
-        await this.ensureAuthenticated();
+        this.ensureAuthenticated();
 
         const cluster = await this.apiClient!.getCluster({
             params: {

src/tools/atlas/listClusters.ts

@@ -12,7 +12,7 @@ export class ListClustersTool extends AtlasToolBase {
     };
 
     protected async execute({ projectId }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
-        await this.ensureAuthenticated();
+        this.ensureAuthenticated();
 
         if (!projectId) {
             const data = await this.apiClient!.listClustersForAllProjects();

src/tools/atlas/listDBUsers.ts

@@ -12,7 +12,7 @@ export class ListDBUsersTool extends AtlasToolBase {
     };
 
     protected async execute({ projectId }: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> {
-        await this.ensureAuthenticated();
+        this.ensureAuthenticated();
 
         const data = await this.apiClient!.listDatabaseUsers({
             params: {

src/tools/atlas/listProjects.ts

@@ -7,7 +7,7 @@ export class ListProjectsTool extends AtlasToolBase {
     protected argsShape = {};
 
     protected async execute(): Promise<CallToolResult> {
-        await this.ensureAuthenticated();
+        this.ensureAuthenticated();
 
         const data = await this.apiClient!.listProjects();