Skip to content

feat: atlas-get-performance-advisor tool: tweak language for slow queries #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylelai1 merged 2 commits into from
Oct 15, 2025
Merged

feat: atlas-get-performance-advisor tool: tweak language for slow queries #645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89ccbcd
Convey the sample of slow queries to the LLM
kylelai1 Oct 13, 2025
e716cae
Tweak copy for slow queries
kylelai1 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/atlas/read/getPerformanceAdvisor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class GetPerformanceAdvisorTool extends AtlasToolBase {
: "No suggested indexes found."
}`,
`## Drop Index Suggestions\n${hasDropIndexSuggestions ? JSON.stringify(dropIndexSuggestionsResult.value) : "No drop index suggestions found."}`,
`## Slow Query Logs\n${hasSlowQueryLogs ? JSON.stringify(slowQueryLogsResult.value?.slowQueryLogs) : "No slow query logs found."}`,
`## Slow Query Logs\n${hasSlowQueryLogs ? `Please notify the user that the slow query logs are limited to the most recent ${DEFAULT_SLOW_QUERY_LOGS_LIMIT} slow query logs. This is a limitation of the MCP server tool only.\n${JSON.stringify(slowQueryLogsResult.value?.slowQueryLogs)}` : "No slow query logs found."}`,
Copy link
Collaborator

@nirinchev nirinchev Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: should we add this clarification only if the number of query logs we've extracted is lower than that limit? And should we include a CTA in the response? Something like "Please notify the user that the slow query logs are limited to the most recent ${DEFAULT_SLOW_QUERY_LOGS_LIMIT} slow query logs. This is done to optimize the performance of the MCP server - they can view the complete list of logs in the Atlas UI" or something similar?

Copy link
Collaborator Author

@kylelai1 kylelai1 Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a CTA to the Atlas UI for specifically the performance advisor is difficult because we need to get the metrics route, which is not as simple as using a group ID and cluster ID. Would need to check with InTel on implementation here as well, since the metrics route is different for flex, dedicated, sharded, etc. PM has decided not to add this step.

I think we should keep the clarification for the limit of slow query logs always so the user is aware of the limit for other cases and not just the current tool call.

If we can't add a CTA, then maybe we can just add that last sentence referencing the Atlas UI? Instead of a specific link to the performance advisor for the cluster, maybe we can link to some docs about accessing the performance advisor in the Atlas UI? What do you think?

Copy link
Collaborator

@nirinchev nirinchev Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was what I meant by CTA - if we can get a link, that'd be great, but otherwise, just telling them they can see more logs if they go to their atlas UI is enough.

Copy link
Collaborator Author

@kylelai1 kylelai1 Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in a CTA for the tool response.

`## Schema Suggestions\n${hasSchemaSuggestions ? JSON.stringify(schemaSuggestionsResult.value?.recommendations) : "No schema suggestions found."}`,
];

Expand Down
Loading