PYTHON-5138 Convert setup_tests.py to a cli#2154
Conversation
NoahStapp
left a comment
NoahStapp
left a comment
There was a problem hiding this comment.
Give this man a medal. A few minor comments, but overall looks great!
| test_vars["TEST_NAME"] = "default_async" | ||
| test_func = FunctionCall(func="run tests", vars=test_vars) | ||
| tasks.append(EvgTask(name=name, tags=tags, commands=[bootstrap_func, test_func])) | ||
|
|
| HERE=$(dirname ${BASH_SOURCE:-$0}) | ||
| . $HERE/env.sh | ||
| SUCCESS=false TEST_FLE_GCP_AUTO=1 bash $HERE/setup-tests.sh | ||
| ./.evergreen/just.sh setup-test kms gcp-fail |
There was a problem hiding this comment.
Is the use of ./.evergreen/just.sh instead of bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh intentional here? It would be nice to use a consistent way of invoking our test cli across test suites.
There was a problem hiding this comment.
These scripts are going away in subsequent PRs.
| OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ | ||
| bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh setup-test | ||
| bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh test-eg | ||
| OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ |
There was a problem hiding this comment.
| OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ | |
| OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ |
There was a problem hiding this comment.
Weird, the UI won't let me accept the suggestion, will apply these manually.
There was a problem hiding this comment.
Wait, this indent was intentional, and like I said, this script is going away.
| bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh setup-test | ||
| bash "${PROJECT_DIRECTORY}"/.evergreen/just.sh test-eg | ||
| OCSP_TLS_SHOULD_SUCCEED="${OCSP_TLS_SHOULD_SUCCEED}" \ | ||
| bash scripts/setup-tests.sh ocsp |
There was a problem hiding this comment.
| bash scripts/setup-tests.sh ocsp | |
| bash scripts/setup-tests.sh ocsp |
| pushd "$(dirname "$(dirname $HERE)")" > /dev/null | ||
| HERE="$( cd -- "$HERE" > /dev/null 2>&1 && pwd )" | ||
| ROOT=$(dirname "$(dirname $HERE)") | ||
| pushd $ROOT > /dev/null |
|
I need to debug why a couple of the tests timed out. |
|
Ah, we weren't properly handling NO_EXT before. I'll have to split those tests into sync and async. |
2 participants
Passing build: https://spruce.mongodb.com/version/67b75da9b482ad000730db61/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC