PYTHON-5172 Remove __init__ from BinaryVector dataclass#2171
Closed
caseyclements wants to merge 1 commit intomongodb:masterfrom
Closed
PYTHON-5172 Remove __init__ from BinaryVector dataclass#2171caseyclements wants to merge 1 commit intomongodb:masterfrom
caseyclements wants to merge 1 commit intomongodb:masterfrom
Conversation
Member
ImportError while loading conftest '/home/runner/work/mongo-python-driver/mongo-python-driver/test/conftest.py'.
test/__init__.py:35: in <module>
from pymongo.uri_parser import parse_uri
pymongo/__init__.py:91: in <module>
from pymongo.asynchronous.mongo_client import AsyncMongoClient
pymongo/asynchronous/mongo_client.py:61: in <module>
from bson.codec_options import DEFAULT_CODEC_OPTIONS, CodecOptions, TypeRegistry
bson/__init__.py:105: in <module>
from bson.binary import (
bson/binary.py:231: in <module>
class BinaryVector:
E ValueError: 'padding' in __slots__ conflicts with class variable |
Contributor
Author
Yeah. This is why I opened this new one up. Thought maybe you or @ShaneHarvey could see the issue. In #2162, I've removed the dataclass decorator. I've already implemented init, repr, and don't want ==, >=.... What do you guys think? |
Member
|
Ah, that explains why we added |
Member
|
I see, then let's close this PR and continue with the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #2162.