PYTHON-5196 Convert OIDC tests to use new test scripts#2194
PYTHON-5196 Convert OIDC tests to use new test scripts#2194blink1073 merged 28 commits intomongodb:masterfrom
Conversation
| elif sub_test_name == "azure-remote": | ||
| source_file = "./env.sh" | ||
| elif sub_test_name == "gcp-remote": | ||
| source_file = "./secrets-export.sh" |
There was a problem hiding this comment.
Why do the azure-remote and gcp-remote envs live in different files?
There was a problem hiding this comment.
They're put there by the scripts in drivers-tools.
There was a problem hiding this comment.
I meant more why do they end up in two different places? I would expect them to be put into the same file by the scripts.
There was a problem hiding this comment.
I blame the author (past me).
There was a problem hiding this comment.
Actually, we can address both of these UX concerns now.
| - func: run tests | ||
| vars: | ||
| TEST_NAME: auth_oidc | ||
| SUB_TEST_NAME: test |
There was a problem hiding this comment.
Can we change the SUB_TEST_NAME from test to something like default for clarity?
There was a problem hiding this comment.
That name corresponds to the OIDC_ENV variable, which is already established.
There was a problem hiding this comment.
There was a problem hiding this comment.
I'll wait to push until we merge the drivers-tools PR and I remove the checkout of my fork.
|
Ready for another look |
2 participants
Passing build: https://spruce.mongodb.com/version/67d1a6e179aa780007b9fbe6/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC