PYTHON-5213 Convert AWS Lambda and Search Index tests to use new test scripts#2205
Merged
blink1073 merged 15 commits intomongodb:masterfrom Mar 19, 2025
Merged
PYTHON-5213 Convert AWS Lambda and Search Index tests to use new test scripts#2205blink1073 merged 15 commits intomongodb:masterfrom
blink1073 merged 15 commits intomongodb:masterfrom
Conversation
Jibola
previously approved these changes
Mar 19, 2025
Contributor
Jibola
left a comment
Jibola
left a comment
There was a problem hiding this comment.
Two non-blocking comments. Overall, LGTM!
| return [ | ||
| create_variant( | ||
| ["test_atlas_task_group_search_indexes"], | ||
| [".index_management"], |
Contributor
There was a problem hiding this comment.
What do you think about making the name more verbose?
Member
Author
There was a problem hiding this comment.
Updated to search_index in all dev-facing places.
|
|
||
| if test_name in ["aws_lambda", "index_management"]: | ||
| env = os.environ.copy() | ||
| env["MONGODB_VERSION"] = "7.0" |
Contributor
There was a problem hiding this comment.
Earlier we set the MONGODB_VERSION to 6.0 for index_management and this is overriding that from the copy. Do we need to set 6.0 whatsoever?
Member
Author
Member
Author
|
Forgot to update markers, new patch build: https://spruce.mongodb.com/version/67daf04c72edb2000767c733/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
Member
Author
|
All green again |
Jibola
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing build: https://spruce.mongodb.com/version/67d47d610f5a9c0007917b13/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC