PYTHON-4940 - Add index hint as an explicit parameter for distinct command.#2225
Merged
NoahStapp merged 2 commits intomongodb:masterfrom Mar 25, 2025
Merged
PYTHON-4940 - Add index hint as an explicit parameter for distinct command.#2225NoahStapp merged 2 commits intomongodb:masterfrom
NoahStapp merged 2 commits intomongodb:masterfrom
Conversation
Member
|
Ah, except typing: |
Contributor
Author
Fixed! |
blink1073
approved these changes
Mar 25, 2025
ShaneHarvey
reviewed
Mar 25, 2025
| if hint is not None: | ||
| if not isinstance(hint, str): | ||
| hint = helpers_shared._index_document(hint) | ||
| cmd["hint"] = hint # type: ignore[assignment] |
Member
There was a problem hiding this comment.
We still need to add tests for this like we do for other helpers that accept hint.
Contributor
Author
There was a problem hiding this comment.
Tests besides the spec tests? The spec tests that verify this change were already present in our repo.
Member
There was a problem hiding this comment.
Yes because we have python specific behavior, like accepting hint="str" and hint=[pairs].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already supported
hintfordistinct()throughkwargs, but we didn't mention it. Now we explicitly support it similarly to the otherCollectionmethods.