PYTHON-4933 - Allow drivers to set bypassDocumentValidation: false on…

[NoahStapp]

… write commands

[ShaneHarvey]

This should be bypass_document_validation: Optional[bool], the arg should still be required.

[ShaneHarvey]

This should be bypass_doc_val: Optional[bool],. It should still be required positional arg in all our internal APIs since the default is never used anyway.

[NoahStapp]

Our current internal APIs expect it to be a keyword argument and not positional. Is changing it to a positional argument intentional here?

[ShaneHarvey]

Previously it was positional:

        write_concern: WriteConcern,
        op_id: Optional[int],
        bypass_doc_val: bool,
        session: Optional[AsyncClientSession],

There's no need to change it to have a default of None because we always pass a value anyway so the default will never be used.

[NoahStapp]

Looks like_insert_one is positional, _update and _update_retryable are keyword arguments. We should unify those so they are consistent. I'd prefer them to all be keyword arguments for clarity.

[ShaneHarvey]

Let's just keep this one as positional and leave the rest.

[ShaneHarvey]

Was this change intentional? It seems unneeded.

[NoahStapp]

Not intended, good catch.