PYTHON-4724 - Prohibit AsyncMongoClient from being used across multiple event loops#2256
Merged
NoahStapp merged 6 commits intomongodb:masterfrom Apr 4, 2025
Merged
PYTHON-4724 - Prohibit AsyncMongoClient from being used across multiple event loops#2256NoahStapp merged 6 commits intomongodb:masterfrom
NoahStapp merged 6 commits intomongodb:masterfrom
Conversation
…ultiple event loop
sleepyStick
previously approved these changes
Apr 2, 2025
ShaneHarvey
requested changes
Apr 3, 2025
pymongo/asynchronous/mongo_client.py
Outdated
| self._closed = False | ||
| self._loop: Optional[asyncio.AbstractEventLoop] = None | ||
| if not _IS_SYNC: | ||
| # Check if the client was created within a running event loop. |
Member
There was a problem hiding this comment.
We can remove this part since it's overly restrictive. We should only bind the loop on the first operation.
ShaneHarvey
reviewed
Apr 3, 2025
pymongo/asynchronous/mongo_client.py
Outdated
| if self._loop is None: | ||
| self._loop = asyncio.get_running_loop() | ||
| else: | ||
| if self._loop != asyncio.get_running_loop(): |
Member
There was a problem hiding this comment.
nit: we could make this an elif
ShaneHarvey
requested changes
Apr 3, 2025
pymongo/asynchronous/mongo_client.py
Outdated
| if self._loop is None: | ||
| self._loop = asyncio.get_running_loop() | ||
| elif self._loop != asyncio.get_running_loop(): | ||
| raise RuntimeError("Cannot use AsyncMongoClient in different event loop") |
Member
There was a problem hiding this comment.
Are there any docs we can point to in this error message? Or can we make it a bit more explanatory?
ShaneHarvey
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.