-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5598 Add generate_config method to ensure auth is tested on free-threaded python 3.14t #2580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-5598 Add generate_config method to ensure auth is tested on free-threaded python 3.14t #2580
Conversation
…: test-standard-auth that only include sharded-clusters
| return tasks | ||
|
|
||
|
|
||
| def create_test_standard_auth_tasks(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the auth variant generation functions so their tasks use test-standard-auth instead of test-non-standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"All auth variant generation methods should have their tasks updated from .test-non-standard to .test-standard-auth to use these new tasks." This line wasn't / isn't clear to me. It appeared like it would be a natural result of the new create_test_standard_auth_tasks().
Do I have to manually edit variants.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you edit the variant function(s) to use the new task tag
|
Disregard Link Check failures. Red herring. |
NoahStapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run a patch build with all of the auth variants?
Patch 379 - Updated create_enterprise_auth_variants (This is more than just the auth variants.) |
Creates new method create_test_standard_auth_tasks that creates tasks "test-standard-auth-*" that only include sharded-cluster. Because the list of clusters is one, we get a task that contains auth and python 3.14t.