RUBY-3723 Add tracing for atlas indexes #2975
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds OpenTelemetry tracing support for Atlas search index operations and enables the corresponding test suite.
Changes:
- Enables atlas_search.yml OpenTelemetry tests by removing them from the skip list
- Adds OpenTelemetry tracing to create_many, drop_one, and update_one operations in the SearchIndex::View class
- Refactors create_one to conditionally include the name parameter only when provided
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/spec_tests/open_telemetry_spec.rb | Removes 'atlas_search.yml' from SKIPPED_OTEL_TESTS to enable OpenTelemetry test coverage for search index operations |
| lib/mongo/search_index/view.rb | Adds tracer delegation and wraps create_many, drop_one, and update_one operations with OpenTelemetry tracing; refactors create_one to only include name when not nil |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamis
left a comment
jamis
left a comment
There was a problem hiding this comment.
Approved, just with a question about the removal of atlas_search.yml from the otel specs.
| base = "#{CURRENT_PATH}/spec_tests/data/open_telemetry" | ||
| OTEL_UNIFIED_TESTS = Dir.glob("#{base}/**/*.yml").sort | ||
| SKIPPED_OTEL_TESTS = [ | ||
| 'bulk_write.yml', 'map_reduce.yml', 'atlas_search.yml' |
There was a problem hiding this comment.
Was this intentional? Given that you're adding tracing support for the atlas indexes here, should these tests remain part of the otel specs?
There was a problem hiding this comment.
The new bulk_write is not yet implemented in the driver; same for map_reduce.
There was a problem hiding this comment.
Oh! My bad, I was reading that backward. I missed that these were skipped tests, and you were thus enabling atlas search tests. 👍 LGTM!
2 participants
No description provided.