test(NODE-7394): add test suite that runs with TLS enabled #4845
+1,074
−326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Jan 22, 2026
| # ssl setup | ||
| SSL=${SSL:-nossl} | ||
| if [ "$SSL" != "nossl" ]; then | ||
| export SSL_KEY_FILE="$DRIVERS_TOOLS/.evergreen/x509gen/client.pem" |
Contributor
Author
There was a problem hiding this comment.
These are not the correct environment variables (and were unused)
baileympearson
commented
Jan 22, 2026
| // 5. Wait 5ms for the connection to become idle. | ||
| beforeEach(async function () { | ||
| client = new MongoClient(this.configuration.url(), { | ||
| client = this.configuration.newClient(this.configuration.url(), { |
Contributor
Author
There was a problem hiding this comment.
use this.configuration.newClient() so that the correct TLS options are provided when TLS is enabled
baileympearson
changed the title
tadjik1
added
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR does two things:
Along the way, I encountered a few issues:
So, some test suites are skipped for now. Other suites have explicit calls to
MongoClient.connect()to avoid NODE-7398.Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript