refactor: convert banners and psas to solidjs (@miodec) #7395
+451
−446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting for review
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
waiting for update
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the banner and PSA (Public Service Announcement) system from a DOM-manipulation-based approach to a reactive SolidJS implementation, improving maintainability and reactivity.
Changes:
- Introduced a new SolidJS store (
banners.ts) to manage banner state reactively - Created a new SolidJS component (
Banners.tsx) for rendering banners - Migrated all
Notifications.addPSA()andNotifications.addBanner()calls to use the newaddBanner()function from the store - Removed the banner-event observable system in favor of SolidJS reactivity
- Removed banner/PSA-specific code from the notifications module
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/ts/stores/banners.ts | New SolidJS store for managing banner state with add/remove/get functions |
| frontend/src/ts/components/layout/overlays/Banners.tsx | New SolidJS component for rendering banners with reactive updates |
| frontend/src/ts/hooks/useTailwindBreakpoints.ts | New hook for tracking Tailwind breakpoints (added but not used in this PR) |
| frontend/src/ts/observables/banner-event.ts | Removed - replaced by SolidJS reactivity |
| frontend/src/ts/states/connection.ts | Updated to use new banner store for offline notifications |
| frontend/src/ts/elements/psa.ts | Migrated PSA banners to use new store |
| frontend/src/ts/elements/notifications.ts | Removed banner/PSA functionality, keeping only notification logic |
| frontend/src/ts/elements/merch-banner.ts | Updated to use new banner store |
| frontend/src/ts/controllers/ad-controller.ts | Replaced BannerEvent subscription with SolidJS createEffect |
| frontend/src/ts/components/layout/overlays/Overlays.tsx | Added Banners component to the layout |
| frontend/src/ts/auth.ts | Updated to use new banner store for account name change banner |
| frontend/src/ts/ape/adapters/ts-rest-adapter.ts | Updated to use new banner store for version mismatch banner |
| frontend/src/index.html | Removed bannerCenter div (now rendered by SolidJS) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions
bot
removed
the
waiting for update
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
waiting for update
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for update
github-actions
bot
removed
the
waiting for update
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.