Skip to content

Conversation

@Mansi-mParticle
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle commented Nov 17, 2025

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Previously, we were adding the selectPlacement attributes first and then applying the user attributes, which would override the initial selectPlacement attributes. This would indicate prioritizing user attributes over selectPlacements attributes.
  • After this PR, we apply the user attributes first and then add the selectPlacements attributes, so any collisions will give the selectPlacement attributes priority.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from a team as a code owner November 17, 2025 21:04
@Mansi-mParticle Mansi-mParticle changed the title Reorder attribute merge to apply user attributes first fix: Reorder attribute merge to apply user attributes first Nov 17, 2025
@Mansi-mParticle Mansi-mParticle force-pushed the fix/reverse-attribute-merge-order branch from b1376d4 to f9d8015 Compare November 17, 2025 21:15
@Mansi-mParticle Mansi-mParticle force-pushed the fix/reverse-attribute-merge-order branch from f39e702 to eeebcf9 Compare November 18, 2025 16:03
@Mansi-mParticle Mansi-mParticle merged commit cf6c9d9 into main Nov 20, 2025
16 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/reverse-attribute-merge-order branch November 20, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants