-
Notifications
You must be signed in to change notification settings - Fork 2
ci: SDKE-548 add CI/CD and semantic release #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: SDKE-548 add CI/CD and semantic release #50
Conversation
release.config.js
Outdated
| [ | ||
| '@semantic-release/github', | ||
| { | ||
| assets: ['dist/FacebookEventForwarder.common.js', 'dist/FacebookEventForwarder.iife.js'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| assets: ['dist/FacebookEventForwarder.common.js', 'dist/FacebookEventForwarder.iife.js'], | |
| assets: ['dist/FacebookEventForwarder.common.js', 'dist/FacebookEventForwarder.iife.js', 'FacebookEventForwarder.esm.js'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you wouldn't have known this, but I was looking in our commit history and looks like someone added the ESM module to the rollup config as an output, so we should include it. this is something we should do for all our other kits as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll review the other kits for ESM outputs and open Sustained Engineering tickets for any that are missing it
rmi22186
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment but otherwise LGTM.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)