Skip to content

Conversation

@jaissica12
Copy link
Contributor

@jaissica12 jaissica12 commented Nov 11, 2025

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Added semantic-release “Release Kit” workflow and removed legacy deployment.
  • Automated versioning, changelog, npm publish, and GitHub release assets.

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@jaissica12 jaissica12 marked this pull request as ready for review November 12, 2025 00:27
[
'@semantic-release/github',
{
assets: ['dist/FacebookEventForwarder.common.js', 'dist/FacebookEventForwarder.iife.js'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assets: ['dist/FacebookEventForwarder.common.js', 'dist/FacebookEventForwarder.iife.js'],
assets: ['dist/FacebookEventForwarder.common.js', 'dist/FacebookEventForwarder.iife.js', 'FacebookEventForwarder.esm.js'],

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wouldn't have known this, but I was looking in our commit history and looks like someone added the ESM module to the rollup config as an output, so we should include it. this is something we should do for all our other kits as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll review the other kits for ESM outputs and open Sustained Engineering tickets for any that are missing it

Copy link
Collaborator

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment but otherwise LGTM.

@jaissica12 jaissica12 requested a review from rmi22186 November 12, 2025 15:07
@rmi22186 rmi22186 merged commit e363c45 into mparticle-integrations:master Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants